Skip to content

fix: indentation for FacebookEventForwarder #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix: indentation for FacebookEventForwarder #58

merged 1 commit into from
Nov 25, 2025

Conversation

@jaissica12
Copy link
Contributor

@jaissica12 jaissica12 commented Nov 25, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Extended existing product attribute mapping functionality to AddToCart and Checkout event.
  • Fixed indentation src/FacebookEventForwarder.js
  • Add related tests

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}
Screenshot 2025-11-25 at 2 36 16 PM Screenshot 2025-11-25 at 2 36 42 PM Screenshot 2025-11-25 at 2 37 20 PM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 changed the title fix: indentation in FacebookEventForwarder.js feat: extend Product Attribute Mapping functionality to AddToCart and Checkout Nov 25, 2025
@jaissica12 jaissica12 marked this pull request as ready for review November 25, 2025 18:57
@jaissica12 jaissica12 requested a review from rmi22186 November 25, 2025 19:39
rmi22186
rmi22186 reviewed Nov 25, 2025
View reviewed changes
@jaissica12 jaissica12 force-pushed the feat/SDKE-643-extend-custom-product-attributes-to-AddToCart-Checkout-event branch from 0e9aea5 to db0e1d6 Compare November 25, 2025 21:07
@jaissica12 jaissica12 changed the title feat: extend Product Attribute Mapping functionality to AddToCart and Checkout fix: indentation for FacebookEventForwarder Nov 25, 2025
@rmi22186 rmi22186 merged commit ea40320 into development Nov 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaissica12 @rmi22186