Skip to content

Conversation

vacuummirror
Copy link

Fixes #3493

Clarifies the sign command help text to reflect actual behavior: the command signs the extension and can upload it to Mozilla Add-ons (AMO). Current description implies local signing only. The CLI and docs support signing and uploading via AMO API keys. Clear wording reduces user confusion and matches README/help output.

@wagnerand-moz
Copy link
Member

Thanks for the PR but this is not accurate. Signing is needed so the add-on can be installed in regular Firefox installations. The signing will happen on Mozilla's servers after uploading and approval.

@vacuummirror
Copy link
Author

Thanks for the clarification. To align --help with README and the command reference:

Proposed help text:
“Submit the extension to Mozilla Add-ons (AMO) for signing so it can be installed in Firefox.”

Rationale from docs:

  • For --channel=listed: creates a listing if needed and uploads a new version.
  • For --channel=unlisted: uploads and returns a signed XPI.
  • Signing occurs on Mozilla’s servers after upload/approval.

If you prefer shorter:
“Submit the extension to AMO for server-side signing.”

lmk if either of these work.

@wagnerand-moz
Copy link
Member

Thanks!

@willdurand do you have a preference here?

@willdurand
Copy link
Member

@willdurand do you have a preference here?

I do not, either is fine by me.

@vacuummirror
Copy link
Author

I guess I'll go with the more detailed one: "Submit the extension to Mozilla Add-ons (AMO) for signing so it can be installed in Firefox."
Thank you so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sign looks like have a wrong name/description: Sign the extension so it can be installed in Firefox but it also for uploading

3 participants