Skip to content

Link to perfcompare instead of comparechooser in perfherder's header #9020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Link to perfcompare instead of comparechooser in perfherder's header #9020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ui/perfherder/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import GraphsView from './graphs/GraphsView';
import AlertsView from './alerts/AlertsView';
import TestsView from './tests/TestsView';
import CompareView from './compare/CompareView';
import CompareSelectorView from './compare/CompareSelectorView';
import CompareSubtestsView from './compare/CompareSubtestsView';
import CompareSubtestDistributionView from './compare/CompareSubtestDistributionView';
import Navigation from './Navigation';
Expand Down Expand Up @@ -111,17 +110,6 @@ class App extends React.Component {
/>
)}
/>
<Route
path={`${path}/comparechooser`}
render={(props) => (
<CompareSelectorView
{...props}
user={user}
projects={projects}
frameworks={frameworks}
/>
)}
/>
<Route
path={`${path}/compare`}
render={(props) => (
Expand Down
9 changes: 7 additions & 2 deletions ui/perfherder/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ const Navigation = ({ user, setUser, notify }) => (
</Link>
</NavItem>
<NavItem>
<Link to="./comparechooser" className="nav-link btn-view-nav">
<a
href="https://perf.compare"
target="_blank"
rel="noopener noreferrer"
className="nav-link btn-view-nav"
>
Compare
</Link>
</a>
</NavItem>
<NavItem>
<Link
Expand Down