Bug1962486 optimize tocommit api #8648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up tocommit function" This reverts commit f117a59.
…eturn results faster
…eturn results faster
…/Andrej1198/treeherder into Bug1962486_optimize_tocommit_api
…/Andrej1198/treeherder into Bug1962486_optimize_tocommit_api
…/Andrej1198/treeherder into Bug1962486_optimize_tocommit_api
…/Andrej1198/treeherder into Bug1962486_optimize_tocommit_api
…/Andrej1198/treeherder into Bug1962486_optimize_tocommit_api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tocommit API currently searches for substrings across all commits and all repositories, this patch limits the search to commits in try and commits in the past 2 months.
The search times went from 14-15 seconds to under 1 second now
We do this by passing a date parameter for each hash and searching for +1 and -2 around the date(I assumed timezones may cause some issues so to be safe I expanded the range a bit)