Skip to content

Lock file maintenance #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Lock file maintenance #4608

merged 1 commit into from
Feb 16, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 11, 2019

This PR contains the following updates:

Update
lockFileMaintenance

🔧 This Pull Request updates package.json lock files to use the latest dependency versions.


Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added dependencies Bot PRs that update dependencies javascript labels Feb 11, 2019
@renovate renovate bot requested a review from sarah-clements February 11, 2019 00:25
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 21 times, most recently from 5f47c17 to f9dd03f Compare February 14, 2019 20:56
@renovate renovate bot closed this Feb 14, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch February 14, 2019 20:56
@edmorley edmorley restored the renovate/lock-file-maintenance branch February 14, 2019 21:09
@edmorley edmorley reopened this Feb 14, 2019
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from a6a6f5f to bcf4c42 Compare February 14, 2019 21:11
@sarah-clements
Copy link
Contributor

@edmorley Why do you think this keeps exceeding the bundle size (I may be missing a point you made in #4586)?

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from a58e427 to a85f851 Compare February 14, 2019 23:59
@edmorley
Copy link
Contributor

React had another point release, so there's another dupe:
https://github.com/mozilla/treeherder/pull/4608/files#diff-8ee2343978836a779dc9f8d6b794c3b2R7786

Until yarn fixes yarnpkg/yarn/issues/3967 or Renovate adds a "consolidate dupes" workaround (perhaps worth filing an issue against Renovate to see if they'd be willing to use one of the workaround packages mentioned in the Yarn issue?) the dupes are unavoidable, and either need manual removal each time React gets an update, or else the threshold bumped up such that it's not exceeded in such cases (with the understanding that the dupes will still exist until the React PR + lockfile PRs are both merged after each release).

@renovate renovate bot closed this Feb 15, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch February 15, 2019 23:24
@sarah-clements sarah-clements restored the renovate/lock-file-maintenance branch February 15, 2019 23:59
@renovate renovate bot closed this Feb 16, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch February 16, 2019 00:51
@sarah-clements sarah-clements restored the renovate/lock-file-maintenance branch February 16, 2019 00:58
@renovate renovate bot closed this Feb 16, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch February 16, 2019 00:59
@sarah-clements
Copy link
Contributor

@edmorley Aghhh, the bot keeps keeps closing the branch! I realized I accidentally merged #4645 that also had a dupe and there are merge conflicts when I try to reopen this branch so I wonder if that is why it keeps closing. I didn't plan out the sequencing for approving these dep upgrades very well... this yarn bug is so frustrating :(

@edmorley
Copy link
Contributor

@edmorley Aghhh, the bot keeps keeps closing the branch!

@rarkins I don't suppose you know what's happening here? (renovatebot/renovate/issues/3018)

@edmorley edmorley restored the renovate/lock-file-maintenance branch February 16, 2019 09:49
@edmorley edmorley reopened this Feb 16, 2019
@renovate renovate bot closed this Feb 16, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch February 16, 2019 09:49
@mozilla mozilla deleted a comment from renovate bot Feb 16, 2019
@edmorley edmorley restored the renovate/lock-file-maintenance branch February 16, 2019 11:23
@edmorley edmorley reopened this Feb 16, 2019
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 1dc9d8c to 8c0a385 Compare February 16, 2019 11:23
@edmorley edmorley removed the request for review from sarah-clements February 16, 2019 11:47
@edmorley edmorley merged commit e3ae8c5 into master Feb 16, 2019
@edmorley edmorley deleted the renovate/lock-file-maintenance branch February 16, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Bot PRs that update dependencies javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants