Bug 1335920 - support both $dumps and $json #2629
Conversation
JSON-e defines `{$json: ..}`, and that's what the actions documentation
says, but Treeherder has been expecting `$dumps`, and the current
`action.json` files use `$dumps`. So this is the first step toward
migrating to the JSON-e standard: make TH accept both. Once this is
deployed, we can switch the in-tree code to generate `$json`. A little
while later, we can switch TH to use JSON-e instead.
|
Do things get deployed immediately on merge, or is there some way to tell when things are deployed? |
|
The prototype (dev) and stage instances auto-deploy from master, prod is deployed by pushing master (or a chosen revision) to the The current status of stage/prod are visible via the What's Deployed tool (linked from the Treeherder help menu) - here. Note at present the stage column is blank due to peterbe/whatsdeployed/issues/1, since @camd is testing a feature branch overnight - however that branch is rebased on top of latest master so does include your change. Since everything looks fine with the various changes on master, I'll do a prod deploy now. |
|
I've given you write access to the repo - feel free to merge when desired :-) |
I spotted an issue with a different PR on stage, so I've held off with the prod deploy for now. After this merges if that other issue isn't resolved I can always cherrypick this to prod if needed to expedite things. |
|
I'm not in a rush, but thanks for the info and the access :) |
JSON-e defines
{$json: ..}, and that's what the actions documentationsays, but Treeherder has been expecting
$dumps, and the currentaction.jsonfiles use$dumps. So this is the first step towardmigrating to the JSON-e standard: make TH accept both. Once this is
deployed, we can switch the in-tree code to generate
$json. A littlewhile later, we can switch TH to use JSON-e instead.
Custom actions have been broken for a few months now (from March 1 until #2619 is deployed) so I am not much more worried than that about breaking things.