Remove all mixins supporting vendor prefixes (Fix #957) #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version removes mixins which added vendor-prefixes. Browser support for these is now excellent. - One migration path is to edit your code to use the unprefixed versions. - Another option is to move these utility mixins into your own code base (though, be aware they are no longer used in Protocol and this will not give you backwards compatible Protocol components). - If you need that level of vendor prefix support consider adding a tool such as [autoprefixer](https://github.com/postcss/autoprefixer) to your code base. - Affected mixins are: - `animation` - `appearance` - `background-size` - `box-decoration-break` - `box-sizing` - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,` - `transform`, `transform-origin`, `transform-style` - `transition`, `transition-property`, `transition-duration`, `transition-delay`
janbrasna
reviewed
Mar 28, 2025
| - `background-size` | ||
| - `box-decoration-break` | ||
| - `box-sizing` | ||
| - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,` |
There was a problem hiding this comment.
Suggested change
| - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,` | |
| - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-items`, `justify-content,` |
| @@ -58,7 +74,7 @@ | |||
| * Update references to the `call-out` SCSS file to `callout` in any `@import` or `@use` rules. | |||
| ** e.g. `@use 'components/call-out';` should change to `@use 'components/callout';` | |||
| * The rebuilt Callout doesn't feature integrated brand logos. Use Logo and Wordmark components instead. | |||
| * The rebuilt Compact Callout lacks an integrated logo, so it no longer positions the logo at one end of the component. A Logo or Wordmark component should appear in the body instead. | |||
| * The rebuilt Compact Callout lacks an integrated logo`, `so it no longer positions the logo at one end of the component. A Logo or Wordmark component should appear in the body instead. | |||
There was a problem hiding this comment.
Suggested change
| * The rebuilt Compact Callout lacks an integrated logo`, `so it no longer positions the logo at one end of the component. A Logo or Wordmark component should appear in the body instead. | |
| * The rebuilt Compact Callout lacks an integrated logo, so it no longer positions the logo at one end of the component. A Logo or Wordmark component should appear in the body instead. |
| - `box-sizing` | ||
| - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,` | ||
| - `transform`, `transform-origin`, `transform-style` | ||
| - `transition`, `transition-property`, `transition-duration`, `transition-delay` |
There was a problem hiding this comment.
Also removed are inline-block (nobody should be using, but still…) and multi-column* mixins; as well as grid*-gap prefixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version removes mixins which added vendor-prefixes. Browser support for these is now excellent.
CHANGELOG.md.Issue
Fix #957
Testing
View the affected components to make sure they are still displaying properly.