Remove PDFJSDev.json from the pre-processor
#19020
Conversation
The `PDFJSDev.json` functionality has never been used much, and there's currently only a single call-site remaining.[1] It's possible to replace that one with `PDFJSDev.eval`, by tweaking the `gulpfile` a little bit, and we can thus simplify the pre-processor code slightly. *Please note:* This can be considered a step towards implementing issue 18563, and once [import attributes](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with) become generally available in (all) browsers and build-tools we can change the `web/chromecom.js` file to use that instead. --- [1] The previous usage was removed over three and a half years ago.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e7033821af8a886/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/feedf07f7e80ab7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/feedf07f7e80ab7/output.txt Total script time: 2.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e7033821af8a886/output.txt Total script time: 7.47 mins
|
Last time I checked, ESLint was the only blocker, but they recently released support for import attributes so it should be fine now. |
Maybe, but that requires fixing issue #17928 first as far as I can tell. (Last time I looked at that, it didn't seem trivial to just update.) |
The
PDFJSDev.jsonfunctionality has never been used much, and there's currently only a single call-site remaining.[1]It's possible to replace that one with
PDFJSDev.eval, by tweaking thegulpfilea little bit, and we can thus simplify the pre-processor code slightly.Please note: This can be considered a step towards implementing issue #18563, and once import attributes become generally available in (all) browsers and build-tools we can change the
web/chromecom.jsfile to use that instead.[1] The previous usage was removed over three and a half years ago.