Skip to content

Add clippy config to travis CI. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SingingTree
Copy link
Contributor

This should have travis run clippy as well as fail if any warnings are
found (not just in clippy, but elsewhere too).

I think this should work, but given the matrix of configs it's possible something breaks, so suggest we keep an eye on travis for a bit if we merge this.

This should have travis run clippy as well as fail if any warnings are
found (not just in clippy, but elsewhere too).
@SingingTree
Copy link
Contributor Author

Looks like something is already unhappy. I'll iterate some more on this and update the PR once I've clobbered the issues.

@SingingTree
Copy link
Contributor Author

Looks like I need to fix:

  • Some of the tests don't play nicely if you check before running the tests. I.e. if you cargo check or cargo clippy then run cargo test --all the tests fail. Not sure why yet, but it's a problem that isn't unique to these changes.
  • There look to be some nightly clippy lints that I missed.

@SingingTree
Copy link
Contributor Author

#187 looks to fix the nightly lint issue. Now to try and fix the issue of cargo check before cargo test breaking the tests.

@SingingTree
Copy link
Contributor Author

#197 is the issue blocking this.

@baumanj
Copy link
Contributor

baumanj commented Mar 4, 2020

Could you do a similar workaround to 6c13760 and move the clippy run after cargo test?

@SingingTree
Copy link
Contributor Author

Could you do a similar workaround to 6c13760 and move the clippy run after cargo test?

Indeed, and it's probably what I should do since I haven't come up with a better solution. That, or doing an extra clean felt like hacks, but probably better than letting this PR rot. I'd been hacking on this in my spare time rather than as a mozilla task, so I'll look for some spare time to get this across the line.

@baumanj
Copy link
Contributor

baumanj commented Mar 11, 2021

Can this be reexamined in light of #281 ?

@SingingTree
Copy link
Contributor Author

Superseded by #282.

@SingingTree SingingTree deleted the add_clippy_to_travis branch March 16, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants