This repository was archived by the owner on Nov 4, 2024. It is now read-only.
Treat insecure __cfduid cookies as insecure #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CloudFlare's insecure cookies are ignored. This commit removes this special treatment. Fixes mozilla#202.
|
Hey @floatingatoll do you think you could review and possible merge this? thanks! |
|
You'll need to wait for the repository owner to proceed.
…On Mon, Apr 15, 2019 at 1:32 PM keks ***@***.***> wrote:
Hey @floatingatoll <https://github.com/floatingatoll> do you think you
could review and possible merge this? thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#379 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFqDDjz7spaViPbHUIODN777PZE6WjDks5vhOHZgaJpZM4b08fy>
.
|
|
It seems she missed the notification. Hey @april, I hope there's no bad blood between us - could you review this? Thanks! |
|
I suspect it's more that, at months to years between replies on some
tickets, that waiting merely 30 days may simply have not been enough.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CloudFlare's insecure cookies are ignored.
This commit removes this special treatment.
Fixes #202.
Sorry for being obnoxious in discussions, don't want to burn anyone out. Here is the fix to the issue. Tests have been updated, not sure it's entirely correct. Maybe it belongs into the "insecure, but HSTS" category.