[pull] main from gpuweb:main #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4542) `textureBindingViewDimesion` for `2d` and `2d-array` are tested as those are defaults but `cube` was not tested. Add some cases. Note: This is semi-round about. It assumes that at least some tests are compatible with cubemaps which require width and height to match and depthOrArrayLayers to be 6. Because of the structure of the tests and the cube requirements not all cases are tested. In particular, compressed cube textures are not testsed. depth and stencil are not tested.
In core it should always be undefined. In compat it should be what was passed in or the default.
Add `isTextureFormatFilterable` and use where things were being checked more manually. Also use `isTextureFormatBlendable` where it was being checked manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )