Skip to content

Upgrade to typescript-eslint v8 #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loganrosen
Copy link

This PR upgrades the dependencies on typescript-eslint to v8, which involves breaking changes in default/recommended rules. I've addressed the new lint failures and adjusted the configuration accordingly. As part of this, I removed glean/types/LocalStorage/index.d.ts, which is no longer used. There are no changelog, documentation, or test changes needed, as this is just a change to linting.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@travis79
Copy link
Member

travis79 commented Mar 3, 2025

@loganrosen Thanks for the contribution, unfortunately we have a low capacity on our team to review, merge, and release this. It might be a little while before we get around to it but I wanted to let you know why it might take a while for this to get some attention.

Thanks again for the PR and we will get to it as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants