Skip to content

Philimon/Fix_cookies_related_tests #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 18, 2025
Merged

Philimon/Fix_cookies_related_tests #843

merged 16 commits into from
Oct 18, 2025

Conversation

philimon-reset
Copy link
Collaborator

@philimon-reset philimon-reset commented Oct 15, 2025 •
edited
Loading

Relevant Links

Bugzilla: 1994055, 1994056
TestRail: _

Description of Code / Doc Changes

  • fixes for test_clear_cookie_data, test_manage_cookie_data and test_never_remember_browsing_history_settings
  • added the required prefs to fix l10n tests

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): Aboutprefs
  • Changes L10n harness

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@philimon-reset philimon-reset self-assigned this Oct 15, 2025
@ben-c-at-moz ben-c-at-moz force-pushed the philimon/fix_clear_and_manage_cookies branch from b96cb81 to 1c9e0e4 Compare October 15, 2025 18:00
@sv-hyacoub sv-hyacoub mentioned this pull request Oct 16, 2025
Closed
11 tasks
Tracy-Walker
Tracy-Walker approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@philimon-reset philimon-reset merged commit 8ecec12 into main Oct 18, 2025
44 of 45 checks passed
@philimon-reset philimon-reset deleted the philimon/fix_clear_and_manage_cookies branch October 18, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tracy-Walker Tracy-Walker Tracy-Walker approved these changes

@ben-c-at-moz ben-c-at-moz Awaiting requested review from ben-c-at-moz

@soncuteanca soncuteanca Awaiting requested review from soncuteanca

Assignees

@philimon-reset philimon-reset

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philimon-reset @Tracy-Walker @ben-c-at-moz