Hani/ Refactor tabs batch 3 #840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/browser_object_tabbar.py
Outdated
| @BasePage.context_chrome | ||
| def reopen_tabs_with_shortcut(self, sys_platform: str, count: int) -> None: | ||
| """Reopen closed tabs using keyboard shortcut Ctrl/Cmd + Shift + T.""" | ||
| actions = self.actions |
There was a problem hiding this comment.
Why is actions set here? Wouldn't just referencing action through self work like you do for the release modifier conditions?
modules/page_object_generics.py
Outdated
| WebElement: The refreshed search field. | ||
| """ | ||
|
|
||
| wait = WebDriverWait(self.driver, wait_time) |
There was a problem hiding this comment.
Do we need to instantiate a new wait instance, or can we instead use the inherited wait instance from the BasePage class?
| # Instantiate objects | ||
| page = GenericPage(driver, url=TEST_URL) | ||
| ba = BrowserActions(driver) | ||
| wait = WebDriverWait(driver, 10) |
There was a problem hiding this comment.
Wherever possible, I believe we should move wait actions to the object models (Create a method there to handle the wait condition instead of instantiating it in the test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: 1990605
TestRail: S2103
Description of Code / Doc Changes
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!