-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove pagerduty client and tests (#314)
- Loading branch information
Showing
9 changed files
with
3 additions
and
168 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ profile](https://docs.aws.amazon.com/cli/latest/userguide/cli-config-files.html) | |
named `default` in the `us-west-2` region we can run: | ||
|
||
```console | ||
docker run --rm mozilla/frost pytest --ignore gsuite/ --ignore heroku/ --ignore pagerduty/ --ignore gcp/ --ignore aws/s3 --ignore aws/ec2 -k test_rds_db_instance_backup_enabled -s --aws-profiles default --debug-calls | ||
docker run --rm mozilla/frost pytest --ignore gsuite/ --ignore heroku/ --ignore gcp/ --ignore aws/s3 --ignore aws/ec2 -k test_rds_db_instance_backup_enabled -s --aws-profiles default --debug-calls | ||
``` | ||
|
||
The options include pytest options: | ||
|
@@ -216,10 +216,6 @@ gsuite: | |
no_activity_since: | ||
years: 1 | ||
months: 0 | ||
pagerduty: | ||
users_with_remote_access_monitoring: 'pd_users.json' | ||
bastion_users: 'hierahash/*hierahash.json' | ||
alternate_usernames: 'alternate_usernames.json' | ||
``` | ||
|
||
### Test Exemptions | ||
|
@@ -429,75 +425,6 @@ gsuite: | |
months: 0 | ||
``` | ||
|
||
### Pagerduty Config | ||
|
||
frost does not query the pagerduty API, but can run tests against output from it. | ||
|
||
The config looks like: | ||
``` | ||
pagerduty: | ||
users_with_remote_access_monitoring: 'pd_users.json' | ||
bastion_users: 'hierahash/*hierahash.json' | ||
alternate_usernames: 'alternate_usernames.json' | ||
``` | ||
|
||
Where `users_with_remote_access_monitoring` and `bastion_users` are | ||
globs for multiple files relative to the current working directory and | ||
`alternate_usernames` is the path to a single file. | ||
|
||
The files have examples formats as follows: | ||
|
||
* `users_with_remote_access_monitoring`: | ||
|
||
```json | ||
[ | ||
{ | ||
"avatar_url": "https://secure.gravatar.com/avatar/...", | ||
"billed": true, | ||
"color": "sea-green", | ||
"contact_methods": [], | ||
"description": null, | ||
"email": "[email protected]", | ||
"html_url": "https://example.pagerduty.com/users/AAA0999", | ||
"id": "AAA0999", | ||
"invitation_sent": false, | ||
"job_title": null, | ||
"name": "Example Examplerton", | ||
"notification_rules": [], | ||
"role": "user", | ||
"self_": "https://api.pagerduty.com/users/AAA0999", | ||
"summary": "C. Hobbes", | ||
"teams": [], | ||
"time_zone": "America/New_York", | ||
"type": "user" | ||
}, | ||
... | ||
] | ||
``` | ||
|
||
* `bastion_users`: | ||
|
||
```json | ||
{ | ||
"chobbes": { | ||
"groups": [""], | ||
"root_ssh": true | ||
}, | ||
"movedon": { | ||
"ensure": "absent" | ||
}, | ||
... | ||
} | ||
``` | ||
|
||
* `alternate_usernames`: | ||
|
||
```json | ||
{ | ||
"chobbes": ["calvin", "spacemanspiff"] | ||
} | ||
``` | ||
|
||
### Test Accuracy | ||
|
||
There are two important things to note about `frost` tests that may be different from your expectations. | ||
|
@@ -646,7 +573,7 @@ Notes: | |
1. Running it we see that one of the IPs is an AWS IP: | ||
|
||
```console | ||
docker run --rm mozilla/frost pytest --ignore aws/ --ignore gsuite/ --ignore heroku/ --ignore pagerduty/ --ignore gcp/ | ||
docker run --rm mozilla/frost pytest --ignore aws/ --ignore gsuite/ --ignore heroku/ --ignore gcp/ | ||
platform darwin -- Python 3.6.2, pytest-3.3.2, py-1.5.2, pluggy-0.6.0 | ||
metadata: {'Python': '3.6.2', 'Platform': 'Darwin-15.6.0-x86_64-i386-64bit', 'Packages': {'pytest': '3.3.2', 'py': '1.5.2', 'pluggy': '0.6.0'}, 'Plugins': {'metadata': '1.5.1', 'json': '0.4.0', 'html': '1.16.1'}} | ||
rootdir: /Users/gguthe/mozilla/frost, inifile: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
21 changes: 0 additions & 21 deletions
21
pagerduty/test_bastion_users_have_pd_remote_monitoring_configured.py
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
pagerduty/test_iam_users_have_pd_remote_monitoring_configured.py
This file was deleted.
Oops, something went wrong.