Skip to content

feat(nimbus): create update leading branch image forms #14086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
moibra05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(nimbus): create update leading branch image forms #14086

moibra05 wants to merge 1 commit into from

Conversation

@moibra05
Copy link
Contributor

@moibra05 moibra05 commented Nov 28, 2025

Because

  • Gives user the ability to change the first image associated with a branch after the experiment has already started

This commit

  • Gives each branch a modal form that allows the first branch image to be changed

Fixes #14015

@moibra05
Copy link
Contributor Author

moibra05 commented Nov 28, 2025

image image image

@moibra05 moibra05 added preview Create Preview Environment pr-preview and removed preview Create Preview Environment labels Nov 28, 2025
yashikakhurana
yashikakhurana reviewed Nov 28, 2025
View reviewed changes
experimenter/experimenter/nimbus_ui/views.py
form.save()
resp = HttpResponse()
resp.headers["HX-Refresh"] = "true"
return resp

Copy link
Contributor

@yashikakhurana yashikakhurana Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh instead of refreshing the whole page, we can use hx-target and hx-swap

Copy link
Contributor Author

@moibra05 moibra05 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be addressed in a future pr b/c closing modals after submitting forms is a little more complicated #14094

yashikakhurana
yashikakhurana reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general implementation looks good, just one minor suggestion. Thank you @moibra05

@moibra05 moibra05 added the preview Create Preview Environment label Nov 28, 2025
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Nov 28, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana requested changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moibra05 some small suggestions to improve, overall its coming good together

freshstrangemusic
freshstrangemusic requested changes Dec 3, 2025
View reviewed changes
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 5, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 5, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 8, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 8, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@moibra05 moibra05 force-pushed the 14015 branch 2 times, most recently from 0c53ac9 to 5453223 Compare December 9, 2025 15:34
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 9, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

2 similar comments
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 9, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 9, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 10, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 10, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moibra05 tested locally, and using pr-preview mode, looks good to me, great job getting this done 🎉

@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 10, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

mozcloud-preview-environments bot commented Dec 10, 2025

Preview environment has been deployed.

Preview URL: https://pr14086-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashikakhurana yashikakhurana yashikakhurana approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pr-preview preview Create Preview Environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create branch image preview and description

5 participants

@moibra05 @jaredlockhart @freshstrangemusic @yashikakhurana