Skip to content

feat(nimbus): Add sorting to deliveries table on featues page. #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

feat(nimbus): Add sorting to deliveries table on featues page. #13711

merged 3 commits into from
Oct 22, 2025
+397 −84

Conversation

@b4handjr
Copy link
Contributor

Because

  • We want to add sorting to the deliveries table

This commit

  • Adds sorting to the deliveries table
  • Fixes formatting issues

Fixes #13707

@b4handjr b4handjr force-pushed the exp-5800-deliveries-sorting branch from ac55ee0 to f58b39e Compare October 17, 2025 17:30
yashikakhurana
yashikakhurana requested changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey can you add tests for the sorting? 🙏

@yashikakhurana yashikakhurana changed the title feat(nimbus): Add pagination to deliveries table on featues page. feat(nimbus): Add sorting to deliveries table on featues page. Oct 20, 2025
@b4handjr b4handjr force-pushed the exp-5800-deliveries-sorting branch from 102b4be to 95ec619 Compare October 20, 2025 21:37
@yashikakhurana yashikakhurana added the preview Create Preview Environment label Oct 21, 2025
@mozcloud-preview-environments
Copy link

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana requested changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one bug on sorting on dates tooltip is stuck
Screenshot 2025-10-21 at 11 17 51 AM

@yashikakhurana yashikakhurana removed the preview Create Preview Environment label Oct 21, 2025
@b4handjr
Copy link
Contributor Author

b4handjr commented Oct 21, 2025 •
edited
Loading

found one bug on sorting on dates tooltip is stuck

Removed the tooltip as it isn't a part of the spec. Since I am using the common/home_sortable_header.html for the header, it was being generated because I had the Launch Date field named as "Dates".

@b4handjr b4handjr force-pushed the exp-5800-deliveries-sorting branch from c43962f to 44d943d Compare October 21, 2025 20:32
@yashikakhurana yashikakhurana added preview Create Preview Environment and removed preview Create Preview Environment labels Oct 22, 2025
@mozcloud-preview-environments
Copy link

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

1 similar comment
@mozcloud-preview-environments
Copy link

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@b4handjr b4handjr mentioned this pull request Oct 22, 2025
Merged
yashikakhurana
yashikakhurana requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @b4handjr its coming along, the other thing I noticed is that on sorting it is kind of shaking the table columns spacing for example here
Screenshot 2025-10-22 at 8 28 51 AM
Screenshot 2025-10-22 at 8 28 36 AM

@yashikakhurana yashikakhurana removed the preview Create Preview Environment label Oct 22, 2025
@b4handjr b4handjr force-pushed the exp-5800-deliveries-sorting branch from 44d943d to 4ec6bbd Compare October 22, 2025 18:37
@yashikakhurana yashikakhurana added the preview Create Preview Environment label Oct 22, 2025
@mozcloud-preview-environments
Copy link

Preview environment has been deployed.

Preview URL: https://pr13711-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

yashikakhurana
yashikakhurana approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything looks perfect, just one suggestion to remove hr from the row to match the same ui as home page, other than that its perfect

@yashikakhurana yashikakhurana removed the preview Create Preview Environment label Oct 22, 2025
@b4handjr b4handjr force-pushed the exp-5800-deliveries-sorting branch from 4ec6bbd to 094e4fc Compare October 22, 2025 19:21
@b4handjr b4handjr enabled auto-merge October 22, 2025 19:21
@b4handjr b4handjr added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 85a6461 Oct 22, 2025
17 checks passed
@b4handjr b4handjr deleted the exp-5800-deliveries-sorting branch October 22, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashikakhurana yashikakhurana yashikakhurana approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add sorting to deliveries table

3 participants

@b4handjr @yashikakhurana