Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cirrus): Add Deployment diagrams #597

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

yashikakhurana
Copy link
Contributor

Description

  • Deployment diagrams for Cirrus

#596

Screenshot 2024-04-24 at 10 02 59 AM

Copy link
Contributor

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes good, this is good. In one diagram we say

  • "Application Backend Container"
  • "Nimbus Web Container"

and in the other we say

  • "Primary Container"
  • "Nimbus Web SIdecar"

to refer to the same containers, so it might be confusing if those names are different even though they're talking about the same things?

I'd say if you want you can just make those names consistent, otherwise I'd say land this and if we need to we can change it later.

But yes thank you for making these 🙏

@yashikakhurana
Copy link
Contributor Author

  • "Application Backend Container"

  • "Nimbus Web Container"

that's a really good point, I have updated the diagram and sticking to this convention

  1. "Application Backend Container"
    
  2. "Nimbus Web Container"
    

Thank you for noticing that

@yashikakhurana yashikakhurana merged commit e25e6d0 into main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants