Skip to content

Bug 2061224 - Make Disconnect idempotent - #7529

Merged
bendk merged 1 commit into
mozilla:mainfrom
bendk:bdk/push-rulvpylkvssv
Aug 7, 2026
Merged

Bug 2061224 - Make Disconnect idempotent#7529
bendk merged 1 commit into
mozilla:mainfrom
bendk:bdk/push-rulvpylkvssv

Conversation

@bendk

@bendk bendk commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

It feels to me like we should treat this the same as we treat CheckAuthorizationStatus and make it valid from all states (https://bugzilla.mozilla.org/show_bug.cgi?id=2059169). WDYT?

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk
bendk requested review from mhammond and skhamis August 6, 2026 14:10
@bendk
bendk force-pushed the bdk/push-rulvpylkvssv branch from f018acc to 2827316 Compare August 6, 2026 14:13

@mhammond mhammond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me I guess.

@bendk
bendk added this pull request to the merge queue Aug 7, 2026
Merged via the queue into mozilla:main with commit 653980f Aug 7, 2026
14 checks passed
@bendk
bendk deleted the bdk/push-rulvpylkvssv branch August 7, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants