Skip to content

Fix FxA state machine spelling - #7528

Open
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-xmnzokuuslnv
Open

Fix FxA state machine spelling#7528
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-xmnzokuuslnv

Conversation

@bendk

@bendk bendk commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

A while back we purposely misspelled "Auth" as "Ath" to get around the Sentry redaction rules. Now that we're using the error ping and Grafana we don't need this anymore.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

A while back we purposely misspelled "Auth" as "Ath" to get around the
Sentry redaction rules.  Now that we're using the error ping and Grafana
we don't need this anymore.
@bendk
bendk requested a review from skhamis August 6, 2026 13:59

@skhamis skhamis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad we don't have to work around this lol

//! In general this means they don't output values for inner fields.
//!
//! Also, they must not use the string "auth" since Sentry will filter that out.
//! Use "ath" instead.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update this too so future us ain't confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants