Consider Firefox < 128 and != 115 as incompatible due to root CA expiration #13502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration For now, this only applies to compatibility checks, so this will cause the add-on detail pages to show the "You need an updated version of Firefox" warning and button to show up instead of the install button for those users.
willdurand
reviewed
Mar 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13502 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 267 267
Lines 10610 10621 +11
Branches 3233 3237 +4
=======================================
+ Hits 10428 10439 +11
Misses 169 169
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
willdurand
approved these changes
Mar 19, 2025
|
Yeah I updated some of them that were in my way but there are a lot of them left... |
KevinMind
pushed a commit
that referenced
this pull request
Mar 19, 2025
…ration (#13502) * Consider Firefox < 128 and != 115 as incompatible due to root CA expiration For now, this only applies to compatibility checks, so this will cause the add-on detail pages to show the "You need an updated version of Firefox" warning and button to show up instead of the install button for those users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this only applies to compatibility checks, so this will cause the add-on detail pages to show the "You need an updated version of Firefox" warning and button to show up instead of the install button for those users.
Fixes mozilla/addons#15475