Skip to content

Commit

Permalink
Merge pull request #614 from artines1/adding-x-com-to-twitter
Browse files Browse the repository at this point in the history
Adding x.com to Twitter's entity.
  • Loading branch information
artines1 authored May 17, 2024
2 parents e899c7d + e597c07 commit 2c57e4b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion disconnect-blacklist.json
Original file line number Diff line number Diff line change
Expand Up @@ -14463,7 +14463,8 @@
"https://twitter.com/": [
"twimg.com",
"twitter.com",
"twitter.jp"
"twitter.jp",
"x.com"
]
}
},
Expand Down
6 changes: 4 additions & 2 deletions disconnect-entitylist.json
Original file line number Diff line number Diff line change
Expand Up @@ -13751,14 +13751,16 @@
"properties": [
"digits.com",
"twitter.com",
"twitter.jp"
"twitter.jp",
"x.com"
],
"resources": [
"ads-twitter.com",
"t.co",
"twimg.com",
"twitter.com",
"twitter.jp"
"twitter.jp",
"x.com"
]
},
"Twyn Group": {
Expand Down
3 changes: 2 additions & 1 deletion social-tracking-protection-blacklist.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
"tweetdeck.com",
"twimg.com",
"twitter.com",
"twitter.jp"

This comment has been minimized.

Copy link
@martinthomson

martinthomson May 17, 2024

@artines1, are you sure that this is right? There are two instances of "twitter.com" above here (lines 30 and 31). Do you need to add an entry for x.com as the top-level domain? (I don't know what the two domains mean...)

This comment has been minimized.

Copy link
@artines1

artines1 May 17, 2024

Author Contributor

There is no first-party concept in the list definition here.

The line30 and line31 is not defined twitter.com as the top-level domain. It’s used to define an entry for twitter.com. Every domain under this entry will be considered a social tracker belongs to twitter.com.

In this case, we specify x.com here means we treat x.com as a social tracker under twitter.com.

"twitter.jp",
"x.com"
]
}
}
Expand Down

0 comments on commit 2c57e4b

Please sign in to comment.