This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Add build_bundles command
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leplatrem
commented
Jul 1, 2024
•
leplatrem
commented
- POC
- Only build for opted in collections
- Align file names with ADR
- Upload to Cloud Storage
alexcottner
reviewed
Jul 3, 2024
alexcottner
reviewed
Jul 3, 2024
| f"{base_url}{DESTINATION_FOLDER}/changesets.zip" | ||
| ) | ||
| if existing_bundle_timestamp is None: | ||
| print("No previous bundle found") # Should only happen once. |
There was a problem hiding this comment.
This could happen multiple times.Ex: if the bundle cannot be built due it being too large.
There was a problem hiding this comment.
The changesets.zip will always be produced (and it's currently ~6MB) so once the job has ran once, the file will be there
alexcottner
reviewed
Jul 3, 2024
| attachments_bundle_filename = f"{bid}--{cid}.zip" | ||
|
|
||
| if not should_bundle: | ||
| bundles_to_delete.append(attachments_bundle_filename) |
There was a problem hiding this comment.
Nice, doing all the writes at the end later will prevent some possible contention issues.
alexcottner
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
This looks great. Things on my mind now:
- We will need to emit some metrics to look at (have a ticket opened for that to follow up on later). We'll have a dashboard with basic stats on it to know how healthy things are.
- We will probably encounter at least 1 unknown after deploying. But since this will be out before any client code is even being tested, that's fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.