Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenants cli #29

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add tenants cli #29

wants to merge 5 commits into from

Conversation

dlactin
Copy link
Member

@dlactin dlactin commented Jan 8, 2025

CHANGES:

  • Created new tenants CLI with the deploymentType subcommand. This could be extended if we want to collect more information from our tenant files.

deploymentType — This subcommand tracks the global and realm-scoped deployment_type value from our tenant files. We can use it to track the progress of ArgoCD migrations and output a CSV file that can be used within our Software Catalogue to track the overall service state.

@dlactin dlactin requested review from hackebrot and a team January 8, 2025 19:00
Copy link
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @dlactin! 🚀

I've added a few comments.

tenants/README.md Outdated Show resolved Hide resolved
tenants/cmd/deploymentType.go Outdated Show resolved Hide resolved
tenants/cmd/deploymentType.go Outdated Show resolved Hide resolved
tenants/cmd/deploymentType.go Outdated Show resolved Hide resolved
tenants/cmd/deploymentType.go Outdated Show resolved Hide resolved
tenants/cmd/root.go Show resolved Hide resolved
tenants/internal/io/input.go Show resolved Hide resolved
tenants/internal/io/input.go Outdated Show resolved Hide resolved
tenants/internal/io/input.go Show resolved Hide resolved
tenants/internal/io/output.go Outdated Show resolved Hide resolved
dlactin and others added 2 commits January 27, 2025 14:17
Co-authored-by: Raphael Aurich <[email protected]>
@hackebrot hackebrot added feature New feature or request app:tenants Changes related to the tenants CLI app labels Jan 28, 2025
@hackebrot
Copy link
Member

Hi @dlactin! 👋🏻

There are a few unaddressed comments (for example: checking output format type, deploymentType subcommand name). What do you think about the proposed changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:tenants Changes related to the tenants CLI app feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants