-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenants cli #29
Open
dlactin
wants to merge
5
commits into
main
Choose a base branch
from
add-tenants-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add tenants cli #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackebrot
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, @dlactin! 🚀
I've added a few comments.
…ct and moved it out of parse function
dlactin
force-pushed
the
add-tenants-cli
branch
from
January 17, 2025 22:27
194e2f6
to
539b57f
Compare
Co-authored-by: Raphael Aurich <[email protected]>
Co-authored-by: Raphael Aurich <[email protected]>
hackebrot
added
feature
New feature or request
app:tenants
Changes related to the tenants CLI app
labels
Jan 28, 2025
Hi @dlactin! 👋🏻 There are a few unaddressed comments (for example: checking output format type, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
deploymentType
subcommand. This could be extended if we want to collect more information from our tenant files.deploymentType
— This subcommand tracks the global and realm-scopeddeployment_type
value from our tenant files. We can use it to track the progress of ArgoCD migrations and output a CSV file that can be used within our Software Catalogue to track the overall service state.