Bug 1939789 - Add icon next to the 'Cookies' choice in the user drop …

…down to be consistent with other menu choices
mozilla-bteam · Jan 4, 2025 · 82dc0f3 · 82dc0f3
1 parent 34c4020
commit 82dc0f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/qa/t/1_test_cookie_consent.t b/qa/t/1_test_cookie_consent.t
@@ -52,7 +52,7 @@ ok($last_order_cookie, 'Last order cookie set properly');
 
 # Change cookie preferences to reject
 $sel->click_ok('header-account-menu-button');
-$sel->click_ok('link=Cookies');
+$sel->click_ok('//a[./span[@data-icon="cookie"]]');
 $sel->wait_for_page_to_load(WAIT_TIME);
 $sel->title_is('Cookie Settings');
 $sel->click_ok('cookie-radio-preference-no');

diff --git a/template/en/default/global/header.html.tmpl b/template/en/default/global/header.html.tmpl
@@ -348,8 +348,11 @@
             </a>
           </li>
           [% IF Param('cookie_consent_enabled') && Bugzilla.cgi.cookie_consent_required %]
-          <li role="presentation">
-            <a href="[% basepath FILTER none %]page.cgi?id=cookies.html" role="menuitem" tabindex="-1">Cookies</a>
+          <li role="none">
+            <a href="[% basepath FILTER none %]page.cgi?id=cookies.html" role="menuitem">
+              <span class="icon" aria-hidden="true" data-icon="cookie"></span>
+              <span class="label" role="none">Cookies</span>
+            </a>
           </li>
           [% END %]
           <li role="separator"></li>