Linting and formatting #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References #5 Signed-off-by: Frederik Krautwald <[email protected]>
This commit adds tslint with prettier to lint and format code in a consistent manner. Closes #5 Signed-off-by: Frederik Krautwald <[email protected]>
Signed-off-by: Frederik Krautwald <[email protected]>
This commit adds husky and lint-staged to enable auto-linting on git commits to ensure consistency among developers. Signed-off-by: Frederik Krautwald <[email protected]>
TylorS
approved these changes
Apr 6, 2019
Member
briancavalier
left a comment
briancavalier
left a comment
There was a problem hiding this comment.
Thanks for doing this! I'm totally in favor of adding linting+formatting. Like we discussed on slack, it'd be great to get as close to standardjs as is possible, since that's what @most/core uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a common editor configuration, linting with tslint, and formatting through prettier. It also sets up auto-linting on git commits through the use of husky and lint-staged to ensure consistency among code contributors. The latter avoids that future commits suddenly will introduce files only because the code was formatted.
This PR closes #5.