Set report output & skip comment #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesj
reviewed
Apr 9, 2024
index.ts
Outdated
| @@ -89,6 +89,7 @@ async function run() { | |||
| try { | |||
| const accessToken = core.getInput('access-token'); | |||
| const limit = Number(core.getInput('limit')); | |||
| const skipComment = core.getInput('skip-comment') === 'true'; | |||
There was a problem hiding this comment.
You can use getBooleanInput I believe.
milesj
reviewed
Apr 9, 2024
index.ts
Outdated
|
|
||
| if (skipComment) { | ||
| core.debug('Skipping comment creation'); | ||
| core.setOutput('comment-created', 'false'); |
There was a problem hiding this comment.
Maybe call saveSummary here also?
|
@rcrowe Looks good, just a few Qs. |
|
Thanks for the comments, will get them sorted tomorrow 🧹 |
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault > A string representing the default value
Address PR comments: - Call saveSummary - Use getBooleanInput
milesj
approved these changes
Apr 10, 2024
|
awesome stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the report to be generated & accessed, but no PR comment raised; this allows more complex workflows to use this action for rendering only.