Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop Injector #23

Closed
wants to merge 2 commits into from
Closed

Desktop Injector #23

wants to merge 2 commits into from

Conversation

lillithkt
Copy link
Contributor

Modified version of injector with the purpouse of being loaded in another electron app, without needing to load another asar file.

An implimentation of this usecase can be found at imlvna/moonlight-desktop

@lillithkt
Copy link
Contributor Author

closing temporarily as the web isnt injecting

@lillithkt lillithkt closed this Dec 13, 2023
@xyzeva
Copy link
Member

xyzeva commented Dec 13, 2023

Your work is failing lint, also please target the develop branch.

@lillithkt lillithkt reopened this Dec 13, 2023
@lillithkt lillithkt changed the base branch from main to develop December 13, 2023 19:37
@lillithkt
Copy link
Contributor Author

closing temporarily as the web isnt injecting

user error

Your work is failing lint, also please target the develop branch.

fixed!

@lillithkt
Copy link
Contributor Author

config file loading is not working :(

@lillithkt lillithkt marked this pull request as draft December 13, 2023 19:45
@NotNite
Copy link
Member

NotNite commented Dec 13, 2023

I'm not sure if I like this:

  • More maintenance burden.
  • The new package is just injector but slightly modified - wouldn't it make more sense to integrate it into injector or something?
  • If we're going to do this, I think a moonlight desktop client would be best official.

@lillithkt
Copy link
Contributor Author

wouldn't it make more sense to integrate it into injector or something

i can try!

I think a moonlight desktop client would be best official.

my plan is to get the client in a workable state, and submit it for review to be made official

@lillithkt
Copy link
Contributor Author

closing in favor of #24

@lillithkt lillithkt closed this Dec 13, 2023
@lillithkt lillithkt mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lillithkt @xyzeva @NotNite