Persistence Helper and matching minified rspack names #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidentally merged something, This pr now includes the \i shortcut in patch finds, as I overlooked adding them there |
xyzeva
requested changes
Dec 17, 2023
| writeFileSync( | ||
| join(ourApp, "injector.js"), | ||
| `require(${JSON.stringify( | ||
| join(__dirname, "../", "../", "injector") |
There was a problem hiding this comment.
dont need the ../ here, .. would work.
| `require(${JSON.stringify( | ||
| join(__dirname, "../", "../", "injector") | ||
| )}).inject( | ||
| require("path").join(__dirname, "../_app.asar") |
There was a problem hiding this comment.
You probably want:
Suggested change
| require("path").join(__dirname, "../_app.asar") | |
| require("path").join(__dirname, "..", "_app.asar") |
| break; | ||
|
|
||
| case "darwin": | ||
| patch(join(dirname(process.execPath), "../", "Resources")); |
There was a problem hiding this comment.
Suggested change
| patch(join(dirname(process.execPath), "../", "Resources")); | |
| patch(join(dirname(process.execPath), "..", "Resources")); |
xyzeva
changed the title
|
Closing for multiple reasons: stale, basing off of Vencord's is a legal grey area, and we have a WIP persistence system in moonlight with 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically re-patches whenever discord updates!
Tested on windows (this is based off Vencord's win32 version) and macos, and i am fairly confident this will work on linux! I will test on linux later tonight