Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more math functions #1700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add more math functions #1700

wants to merge 1 commit into from

Conversation

Kaida-Amethyst
Copy link
Contributor

@Kaida-Amethyst Kaida-Amethyst commented Feb 24, 2025 •
edited
Loading

For Closing issue #1693

Add the Following math functions, for double, float type, and math module.

  • hyperbolic functions: sinh, cosh, tanh
  • inverse hyperbolic functions: asinh, acosh, atanh.
  • cube root: cbrt
  • Logarithmic utility: log1p
  • Exponential utility: expm1
  • Hypotenuse calculation: hypot

@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 5506

Details

  • 124 of 139 (89.21%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 92.453%
Changes Missing Coverage Covered Lines Changed/Added Lines %
double/hypot_nonjs.mbt 4 5 80.0%
double/exp_nonjs.mbt 21 25 84.0%
double/log_nonjs.mbt 19 23 82.61%
double/hyperbolic_nonjs.mbt 53 59 89.83%
Totals Coverage Status
Change from base Build 5504: -0.07%
Covered Lines: 5990
Relevant Lines: 6479
💛 - Coveralls

@Lampese Lampese self-requested a review February 24, 2025 09:23
@Kaida-Amethyst Kaida-Amethyst force-pushed the more_math_functions branch 4 times, most recently from 358a709 to 115c2f0 Compare February 27, 2025 03:56
@Kaida-Amethyst Kaida-Amethyst marked this pull request as ready for review February 27, 2025 04:09
@Kaida-Amethyst Kaida-Amethyst changed the title add more math functions [WIP] add more math functions Feb 27, 2025
@Lampese Lampese requested a review from tonyfettes February 27, 2025 12:16
tonyfettes
tonyfettes requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@tonyfettes tonyfettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename ln_1p to ln1p? For the rest of the change LGTM.

tonyfettes
tonyfettes approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@tonyfettes tonyfettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with ln_1p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyfettes tonyfettes tonyfettes approved these changes

@Lampese Lampese Lampese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaida-Amethyst @coveralls @tonyfettes @Lampese