Skip to content

Conversation

@meguruli
Copy link
Contributor

@meguruli meguruli commented Nov 4, 2025

Port Seq from Haskell to MoonBit #135(https://github.com/moonbit-community/Community-Tasks/issues/135#issue-3508586688)
移植 Haskell 语言中的 Seq 到 MoonBit, 实现 Data.equence 的大部分接口,并对每个接口,都提供黑盒测试, 在 README.mbt.md 中提供使用示例。

@peter-jerry-ye-code-review
Copy link

Submodule addition lacks visibility into actual implementation

Category
Maintainability
Code Snippet
+Subproject commit 906d11d400b036e17dead2113227cd1faeb505a8
Recommendation
Include the actual source files in the main repository or provide the diff of the submodule contents for proper code review
Reasoning
Code review cannot be effectively performed on submodule references alone. The actual MoonBit implementation, tests, and documentation need to be visible to assess correctness, performance, and maintainability of the Seq data structure port from Haskell.

@meguruli
Copy link
Contributor Author

meguruli commented Nov 4, 2025

说明

本 PR 添加了基于 Finger Tree 的序列数据结构实现。

关于 CI 失败:当前 CI 失败是由于项目中其他模块使用了已弃用的方法定义语法。
本 PR 新增的 seq 模块完全遵循新的语法规范,不存在语法问题。

@Lampese Lampese merged commit 32d7e80 into moonbit-community:main Nov 4, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants