-
Notifications
You must be signed in to change notification settings - Fork 45
Log into Docker Hub #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Log into Docker Hub #342
Conversation
Docker have implemented rate limiting that this repository hits.
I've added an oragnisation level pair of secrets for this with read-only access to our dockerhub creds. We'll hit this in other repos. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 30.90% 30.90%
=======================================
Files 71 71
Lines 3229 3229
=======================================
Hits 998 998
Misses 2231 2231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2507413
to
3fdff4b
Compare
Okay, so the secrets are not available if the run is triggered from a fork. Not sure how to get around this because the new rate limit is killing us. |
Docker have implemented rate limiting that this repository hits.