Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrooveScribe 3 Toms #34

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

GrooveScribe 3 Toms #34

wants to merge 6 commits into from

Conversation

BenT-o
Copy link

@BenT-o BenT-o commented Mar 29, 2021

This branch offers functionality for a Mid Tom using the existing samples in the GrooveScribe files. The previous upper tom sample has been used for the mid tom, and an unused '10 Tom' sample is the new high tom. Ideally a fresh set of matching samples would be good, but with what is here this seems to work just fine!

Also a small cosmetic change to remove the horizontal lines between buttons only to avoid confusion about where the notes are placed on the sheet music.

@MDJLengers
Copy link

I used your code and it works perfectly. many thanx!! Finally a third Tom

@BenT-o
Copy link
Author

BenT-o commented Jan 19, 2022

I used your code and it works perfectly. many thanx!! Finally a third Tom

You're welcome! Glad it's been of use. :)

@MDJLengers
Copy link

Hello BenT-o,

After using your code I found out that there is a problem with it. Please check if this is the case, maybe i'm doing something wrong. The problem is when you change the 4/4 in for example a 6/8 beat and you put the notes in, everything seems alright. Then I copy the embeded code and use it on my website. Still everything is alright. The html code seems just fine. But when you look at it when it's online it suddenly is a 4/4 again instead of a 6/8.
Using only a 4/4 it works perfect but every other 3/4, 4/6 etc. turns into a 4/4.

Does this happen with your code to or not?

@MDJLengers
Copy link

Hello Bent-o,

I solved the problem with the time signature. I found out that it's not your code that's wrong. I use the wordpress advanced iframe plugin for automatic height calculation of the iframe. Somehow this plugin is the problem.

@laurentpl
Copy link

Hi Bent-o,

Thank you so much for adding mid tom !
It works great 🥰

At least, it works great on my mac...
But when I use it on my iPhone with safari (or chrome), the tom 2 is muted.
Any idea of what happen ?

Thank so much again !
Laurent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants