Skip to content

Conversation

lyuich
Copy link
Contributor

@lyuich lyuich commented Feb 26, 2019

Checklist

  • 1. Add IDEWorkspaceChecks.plist to the repository which is generated after Xcode 9.3
  • 2. Update Carthage for Xcode 10.1.0 (Swift 4.2.1)
  • 3. Update the version of Xcode from 9.2.0 to 10.1.0 on CircleCI
  • 4. Convert automatically from Swift 4.0.3 to Swift 4.2
  • 5. Fix all warnings

Motivation and Context

Build failed on CircleCI because the latest swiftlint requires Xcode 10.0 to be installed.
So, I updated Xcode (local and CircleCI) and Carthage (RxSwift).

Description

  1. The following is the reason why I committed IDEWorkspaceChecks.plist
Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace’s shared data, to store the state of necessary workspace checks.
Committing this file to source control will prevent unnecessary rerunning of those checks for each user opening the workspace.
  1. Xcode 10.1.0 requires to update RxSwift for Swift 4.2.1
/Users/lyuich/.go/src/github.com/lyuich/sample-ios-swift/sample-ios-swift/ViewController.swift:12:8: 
Module compiled with Swift 4.0.3 cannot be imported by the Swift 4.2.1 compiler:
/Users/lyuich/.go/src/github.com/lyuich/sample-ios-swift/Carthage/Build/iOS/RxSwift.framework/Modules/RxSwift.swiftmodule/x86_64.swiftmodule
  1. The latest version of swiftlint requires Xcode 10.0 or later
$ brew install swiftlint

swiftlint: A full installation of Xcode.app 10.0 is required to compile this software.
Installing just the Command Line Tools is not sufficient.
Xcode 10.0 cannot be installed on macOS 10.12.
You must upgrade your version of macOS.
Error: An unsatisfied requirement failed this build.
Exited with code 1

Screenshot

  1. Build failed on CircleCI because the latest swiftlint requires Xcode 10.0 to be installed.

brew_install_swiftlint

swiftlint_requires_xcode_10

Reference

@lyuich lyuich self-assigned this Feb 26, 2019
@lyuich lyuich changed the title [WIP] Update the version of Xcode from 9.2.0 to 10.1.0 Update the version of Xcode from 9.2.0 to 10.1.0 Feb 26, 2019
@lyuich lyuich changed the title Update the version of Xcode from 9.2.0 to 10.1.0 [WIP] Update the version of Xcode from 9.2.0 to 10.1.0 Feb 26, 2019
@lyuich lyuich requested a review from noboru-i February 26, 2019 06:05
@ml-bot-public
Copy link

2 Warnings
⚠️ PR is classed as Work in Progress
⚠️ a large PR

Generated by 🚫 Danger

@lyuich
Copy link
Contributor Author

lyuich commented Feb 26, 2019

Notes:

1. The webhook of CircleCI didn't work on push events

This problem was fixed according to the following steps.

Troubleshooting when Circle doesn't build after pushes to GitHub - Build Environment - CircleCI Discuss

  1. Remove all CircleCI webhooks and services from your GitHub repo settings.
  2. Unfollow the project on CircleCI through “Project settings”.
  3. Re-follow the project on CircleCI.

Then, the trigger worked after pushing only the hash change using git commit --amend by force

lyuich force-pushed the lyuich:xcode-10-1 branch from 025565a to e709b87

2. GitHub Access Token for Danger was missing on CircleCI

The problem was solved by setting the Pass secrets to builds from forked pull requests option active.

CircleCI - Jobs monstar-lab/sample-ios-swift pull/6 74 (build)

3. INTERNAL ERROR: Uncaught exception occurred during bundle exec fastlane test on CircleCI

CircleCI - Jobs monstar-lab/sample-ios-swift pull/6 76 (build failed)
CircleCI - Jobs monstar-lab/sample-ios-swift pull/6 77 (build succeed)

The same problem occurs on Azure Pipelines, Travis CI, TeamCity, etc.

Assertion failure in ROCKRemoteProxy (Xcode Build Task, Hosted Agent, MacOS) · Issue #8840 · Microsoft/azure-pipelines-tasks

This problem seems to be related to Xcode 10.1
I'll try to update the version of Xcode from 9.2.0 to 10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants