Update for current Google Cloud documentation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elecnix
force-pushed
the
es6
branch
3 times, most recently
from
e928c1c to
5da37aa
Compare
|
@monotosh-k can you please review this PR? |
|
Hey, do you got this working ? I am wondering if you could provide a docker or something because there are too many errors to begin with ... |
Yes, I got it working! Did you try from my elecnix:es6 fork? |
|
Yes, it did, thanks! I forgot to switch the branch haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to parse the current version of Google Cloud documentation.
The code assumed an old version of the documentation, which had different CSS styles. Also, there is no sub-product navigation, so it is removed from the CLI options.
Modernized to an ES6 module instead of CommonJS. Tested on Node v20.10.0.
A very old version of Puppeteer was in use, and needed an update.
Removed cheerio which did not seem necessary, since Puppeteer can pass query selectors to the document.