Skip to content

refactor: solid personal bests modal (@d1rshan) #8009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
d1rshan wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

refactor: solid personal bests modal (@d1rshan) #8009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
da6e281
wip
d1rshan May 23, 2026
89217f8
fix lint
d1rshan May 23, 2026
62476b9
move modal to user profile
d1rshan May 23, 2026
db3adc5
move back to modals
d1rshan May 23, 2026
874e22f
temp mock data
d1rshan May 23, 2026
c98c28e
fix scroll conflict
d1rshan May 23, 2026
b5bff16
remove bg for mode2
d1rshan May 23, 2026
1035f2f
cleanup
d1rshan May 23, 2026
8828b20
use table component (wip)
d1rshan May 23, 2026
3ffd893
cleanup
d1rshan May 23, 2026
8cfb8bd
more cleanup
d1rshan May 23, 2026
a61f1c6
rm bg and sticky
d1rshan May 23, 2026
79c2e71
fix type
d1rshan May 23, 2026
a45ea97
tweaks
d1rshan May 27, 2026
32d6d4c
move overflow contain to animated modal
d1rshan May 27, 2026
5ca9308
show mode2 for all rows with lower opacity
d1rshan May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions frontend/src/html/popups.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,35 +58,6 @@
</div>
</div>

<dialog id="pbTablesModal" class="modalWrapper hidden">
<div class="modal">
<table>
<thead>
<tr>
<td width="1%">words</td>
<td>
<span class="unit">wpm</span>
<br />
<span class="sub">accuracy</span>
</td>
<td>
raw
<br />
<span class="sub">consistency</span>
</td>
<td>difficulty</td>
<td>language</td>
<td>punctuation</td>
<td>numbers</td>
<td>lazy mode</td>
<td>date</td>
</tr>
</thead>
<tbody></tbody>
</table>
</div>
</dialog>

<dialog id="practiseWordsModal" class="modalWrapper hidden">
<div class="modal" actions="">
<div class="title">Practice words</div>
Expand Down
68 changes: 0 additions & 68 deletions frontend/src/styles/popups.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,74 +259,6 @@ body.darkMode {
}
}

#pbTablesModal {
.modal {
max-width: 100%;
overflow-y: scroll;
table {
border-spacing: 0;
border-collapse: collapse;
color: var(--text-color);

tbody {
clip-path: inset(0);
}

td {
padding: 0.5rem 0.5rem;
}

.modesticky {
position: sticky;
top: calc(1rem - 2px);
z-index: 2;
}

thead {
color: var(--sub-color);
font-size: 0.75rem;
position: sticky;
top: -2rem;
background-color: var(--bg-color) !important;
z-index: 3;
}

tbody tr.odd {
background: var(--sub-alt-color);
}

tbody tr.even {
background: var(--bg-color);
}

td.infoIcons span {
margin: 0 0.1rem;
}
.miniResultChartButton {
opacity: 0.25;
transition: 0.25s;
cursor: pointer;
&:hover {
opacity: 1;
}
}
.sub {
opacity: 0.5;
}
td {
text-align: right;
}
td:nth-child(6),
td:nth-child(7) {
text-align: center;
}
tbody td:nth-child(1) {
font-size: 1.5rem;
}
}
}
}

#importExportSettingsModal {
.modal {
max-width: 900px;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/components/common/AnimatedModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export function AnimatedModal(props: AnimatedModalProps): JSXElement {
>
<div
class={cn(
"modal pointer-events-auto grid h-max max-h-full w-full max-w-md gap-4 overflow-auto rounded-double bg-bg p-4 text-text ring-4 ring-sub-alt sm:p-8",
"modal pointer-events-auto grid h-max max-h-full w-full max-w-md gap-4 overflow-auto overscroll-y-contain rounded-double bg-bg p-4 text-text ring-4 ring-sub-alt sm:p-8",
props.modalClass,
)}
ref={modalRef}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/ts/components/modals/Modals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { CustomTestDurationModal } from "./CustomTestDurationModal";
import { CustomTextModal } from "./CustomTextModal";
import { CustomWordAmountModal } from "./CustomWordAmountModal";
import { MobileTestConfigModal } from "./MobileTestConfigModal";
import { PbTablesModal } from "./PbTablesModal";
import { AddPresetModal } from "./preset/AddPresetModal";
import { EditPresetModal } from "./preset/EditPresetModal";
import { QuoteRateModal } from "./QuoteRateModal";
Expand All @@ -31,6 +32,7 @@ export function Modals(): JSXElement {
<QuoteSearchModal />
<CustomTestDurationModal />
<CustomWordAmountModal />
<PbTablesModal />
<ShareTestSettings />
<MobileTestConfigModal />
<CookiesModal />
Expand Down
Loading
Loading