fix(tape mode): support mixed-direction words (@nadalaba)#7792
Open
nadalaba wants to merge 10 commits into
Open
fix(tape mode): support mixed-direction words (@nadalaba)#7792nadalaba wants to merge 10 commits into
nadalaba wants to merge 10 commits into
Conversation
also center current letter, so that it stays in the same position in RTL and LTR tape
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
Bot
added
the
waiting for update
github-actions
Bot
added
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes tape-mode scrolling/caret positioning when individual words have different text direction than the overall test, improving mixed LTR/RTL behavior.
Changes:
- Update tape scroll math to account for per-word direction (incl. “center current letter” adjustments).
- Adjust caret tape offset calculations for RTL tests.
- Load funbox CSS files asynchronously and wait for them to finish loading.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/ts/test/test-ui.ts | Updates scrollTape() width/margin calculations for mixed-direction words. |
| frontend/src/ts/test/funbox/funbox.ts | Changes funbox CSS application to async load/wait for stylesheets. |
| frontend/src/ts/elements/caret.ts | Refines caret positioning in tape mode, incl. RTL tape margin handling. |
Miodec
added
waiting for update
github-actions
Bot
removed
the
waiting for update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.