Skip to content

feat: Caps Lock Off (@Leonbacd123) #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Leonabcd123
Copy link

@Leonabcd123 Leonabcd123 commented May 24, 2025

Description

Added a settting that allows the user to disable Caps Lock. Even if the user accidentally presses Caps Lock in the middle of a test, it will be ignored and the input will still be lowercase.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff packages Changes in local packages labels May 24, 2025
Copy link

sentry-io bot commented May 24, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/controllers/input-controller.ts

Function Unhandled Issue
isCharCorrect Error: activeWord is undefined - can't update active element ...
Event Count: 14 Affected Users: 26
📄 File: frontend/src/ts/pages/settings.ts (Click to Expand)
Function Unhandled Issue
initGroups Error: Failed to find a button element for smoothCaret /se...
Event Count: 9 Affected Users: 9
initGroups Error: Failed to find a button element for fontFamily /set...
Event Count: 1 Affected Users: 155
---

Did you find this useful? React with a 👍 or 👎

@Leonabcd123 Leonabcd123 changed the title feat: Caps Lock Off feat: Caps Lock Off (@Leonbacd123) May 24, 2025
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels May 24, 2025
@Miodec
Copy link
Member

Miodec commented May 26, 2025

Im honestly not sure if this setting is really needed, feels like too much hand holding for the user. Sorry.

@Miodec Miodec closed this May 26, 2025
@Leonabcd123
Copy link
Author

Leonabcd123 commented May 26, 2025

Sorry Miodec, just thought it will be a good idea because I saw some people using external software to disable their Caps Lock.

@Leonabcd123
Copy link
Author

Leonabcd123 commented May 26, 2025

Im honestly not sure if this setting is really needed, feels like too much hand holding for the user. Sorry.

I'm also working on a feature that allows the user to create their own layouts and save them locally. Would you be interested in that?

@fehmer
Copy link
Member

fehmer commented May 26, 2025

Im honestly not sure if this setting is really needed, feels like too much hand holding for the user. Sorry.

I'm also working on a feature that allows the user to create their own layouts and save locally. Would you be interested in that?

there was already an attempt to implement something like this: #6375

@Leonabcd123
Copy link
Author

Leonabcd123 commented May 27, 2025

Im honestly not sure if this setting is really needed, feels like too much hand holding for the user. Sorry.

I'm also working on a feature that allows the user to create their own layouts and save locally. Would you be interested in that?

there was already an attempt to implement something like this: #6375

I was thinking of doing something where you have a keymap, and you can edit each key in it, instead of doing something where you import a layout in text. What do you think of that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff packages Changes in local packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants