Skip to content

style: it's the definitive or most recognized (@saugat1070) #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

saugat1070
Copy link

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added the docs Related to Markdown files and documentation label May 4, 2025
@saugat1070 saugat1070 changed the title it's the definitive or most recognized feat: it's the definitive or most recognized May 4, 2025
@saugat1070 saugat1070 changed the title feat: it's the definitive or most recognized style: it's the definitive or most recognized -by SaugatGiri May 4, 2025
@saugat1070 saugat1070 changed the title style: it's the definitive or most recognized -by SaugatGiri style: it's the definitive or most recognized – by SaugatGiri May 4, 2025
@Diamonds85
Copy link

The only problem is the title. change it to this, style: it's the definitive or most recognized (@saugat1070), and the change you are proposing is grammatically incorrect as the most recognized would be typeracer. There are more websites than monkeytype for typing tests, so it is definitely not definitive. 'The' is referring to 'typing test' or 'minimalistic' not Monkeytype, and those terms are vague/undefinitive.

@saugat1070 saugat1070 changed the title style: it's the definitive or most recognized – by SaugatGiri style: it's the definitive or most recognized (@saugat1070) May 5, 2025
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 5, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 5, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 5, 2025
@Miodec
Copy link
Member

Miodec commented May 7, 2025

Id rather stay humble in the readme. Thanks though.

@Miodec Miodec closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. docs Related to Markdown files and documentation frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants