Skip to content

Conversation

@EspenAlbert
Copy link
Collaborator

Description

Uses delete_on_create_timeout with default=true support across TPF resources

Link to any related issue(s): CLOUDP-343190

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Config: updateStepNoWait,
Check: updateStep.Check,
},
// Changes: skip_wait_on_update true -> null
Copy link
Collaborator Author

@EspenAlbert EspenAlbert Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summarizes the change in behavior well.
The old way allowed updating to null while the new way keeps the state value if removed (UseStateForUnknown behavior).

This is why we need the ImportStateVerifyIgnore: []string{"delete_on_create_timeout"} in import as it will not be present in the state after import.
Because once the value has been used in create it remains unchanged.

Note: A fresh import and setting delete_on_create_timeout in the config will raise an update error saying it cannot be updated.

Config: configWithTimeout(timeoutsStrLongFalse),
Check: resource.TestCheckResourceAttr(resourceID, "delete_on_create_timeout", "false"),
Config: configWithTimeout(timeoutsStrLongFalse),
ExpectError: regexp.MustCompile("delete_on_create_timeout cannot be updated or set after import .*"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of error message when trying to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant