feat: Adds support for alertConfiguration.severityOverride attribute #3795

ciprian-tibulca · 2025-10-20T17:04:07Z

Description

CLOUDP-313016: add support for alertConfiguration.severityOverride attribute

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
[ x I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

…ribute

github-actions · 2025-10-23T16:49:52Z

APIx bot: a message has been sent to Docs Slack channel

lantoli · 2025-10-23T19:13:54Z

contributing/testing-best-practices.md

 - `Basic import tests` are done as the last step in the `basic acceptance tests`, not as a different test, e.g. [basicTestCase](https://github.com/mongodb/terraform-provider-mongodbatlas/blob/66c44e62c9afe04ffe8be0dbccaec682bab830e6/internal/service/searchindex/resource_search_index_test.go#L211). Exceptions apply for more specific import tests, e.g. testing with incorrect IDs. [Import tests](https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/import#resource-acceptance-testing-implementation) verify that the [Terraform Import](https://developer.hashicorp.com/terraform/cli/import) functionality is working fine.
 - Data sources are tested in the same tests as the resources, e.g. [commonChecks](https://github.com/mongodb/terraform-provider-mongodbatlas/blob/66c44e62c9afe04ffe8be0dbccaec682bab830e6/internal/service/searchindex/resource_search_index_test.go#L262-L263).
 - Helper functions such as `resource.TestCheckTypeSetElemNestedAttrs` or `resource.TestCheckTypeSetElemAttr` can be used to check resource and data source attributes more easily, e.g. [resource_serverless_instance_test.go](https://github.com/mongodb/terraform-provider-mongodbatlas/blob/66c44e62c9afe04ffe8be0dbccaec682bab830e6/internal/service/serverlessinstance/resource_serverless_instance_test.go#L61).
+- Note: before running the acceptance tests, make sure you set the environment variable `TF_ACC=1`.


nit: my recommendation is to use the Make target that already adds it for you, e.g.:

ACCTEST_PACKAGES=./internal/service/databaseuser ACCTEST_REGEX_RUN='TestAccDatabaseUser_basic' make testacc

my note is based on the VS Code run/debug experience, which is most likely what most repo contributors will use, wdyt?

lantoli · 2025-10-23T19:34:03Z

internal/service/alertconfiguration/model_test.go

 				Enabled:               types.BoolValue(true),
 			},
 		},
+		{


it's previous to this PR but consider to have the testCase as a map[string]struct... with test name as keys, we're using this format in most tests

lantoli · 2025-10-23T19:35:19Z

.changelog/3795.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+data-source/mongodbatlas_alert_configuration: Adds `severity_override` attribute


also in plural data source?

lantoli · 2025-10-23T19:38:26Z

internal/service/alertconfiguration/resource_test.go

+				Config: configWithSeverityOverride(projectID, "WARNING"),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					checkExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "project_id", projectID),


in TPF (terraform-plugin-framework) resources, only computed attributes are interested to be checked, values provided in the config don't need to be checked because that's a TF guarantee.

it's especially useful for data source where most attributes are computed, and for computed attributes in resources

(we still have these checks in many TPF tests, for SDKv2 they're needed)

I removed these checks added by this PR, but would prefer to defer the cleanup for previous tests.

lantoli · 2025-10-23T19:39:51Z

.changelog/3795.txt

+data-source/mongodbatlas_alert_configuration: Adds `severity_override` attribute
+```
+
+```release-note:enhancement


documentation for the new attribute is not updated, or will be in a follow-up PR? (update is small so could go here)

lantoli · 2025-10-23T19:51:11Z

if branch name is correct, CLOUDP-31301 in PR description is missing the last number, should be CLOUDP-313016 (which is an epic instead of story)

marcosuma

Thanks! Leo brings up a couple of good points, good to address those first

internal/service/alertconfiguration/model_test.go

EspenAlbert · 2025-10-24T08:58:28Z

internal/service/alertconfiguration/resource.go

 				},
 			},
+			"severity_override": schema.StringAttribute{
+				Optional: true,


just to double check: This is never returned by the API unless defined by the user? How do the user reset the attribute?

This is never returned by the API unless defined by the user?

correct

How do the user reset the attribute?

as of now, this flag cannot be cleared (if not set in the PUT request body it won't be reset). Same happens from UI too, I will open a ticket with the owning team.
I added a note in the docs about explicitly setting it to ERROR (the default).

EspenAlbert · 2025-10-24T09:00:20Z

Related issue is unrelated?

AgustinBettati · 2025-10-24T10:37:53Z

internal/service/alertconfiguration/resource_test.go

+		Steps: []resource.TestStep{
+			{
+				Config: configWithSeverityOverride(projectID, "WARNING"),
+				Check: resource.ComposeAggregateTestCheckFunc(


We can add an additional step modifying the value, and also capture behaviour of what happens when attribute is removed (related to Espen thread).

ciprian-tibulca added 2 commits October 20, 2025 18:02

CLOUDP-31301: add support for alertConfiguration.severityOverride att…

9e62e14

…ribute

CLOUDP-31301: add support for alertConfiguration.severityOverride att…

ae82057

…ribute

ciprian-tibulca changed the title ~~[DRAFT] CLOUDP-31301: add support for alertConfiguration.severityOverride attribute~~ feat: add support for alertConfiguration.severityOverride attribute Oct 23, 2025

ciprian-tibulca changed the title ~~feat: add support for alertConfiguration.severityOverride attribute~~ feat: Adds support for alertConfiguration.severityOverride attribute Oct 23, 2025

github-actions bot added the enhancement label Oct 23, 2025

CLOUDP-31301: add changelog entry and lint fix

4adac12

ciprian-tibulca marked this pull request as ready for review October 23, 2025 16:49

ciprian-tibulca requested review from a team as code owners October 23, 2025 16:49

lantoli reviewed Oct 23, 2025

View reviewed changes

marcosuma reviewed Oct 24, 2025

View reviewed changes

internal/service/alertconfiguration/model_test.go Show resolved Hide resolved

EspenAlbert reviewed Oct 24, 2025

View reviewed changes

AgustinBettati reviewed Oct 24, 2025

View reviewed changes

		@@ -0,0 +1,7 @@
		```release-note:enhancement
		data-source/mongodbatlas_alert_configuration: Adds `severity_override` attribute

feat: Adds support for alertConfiguration.severityOverride attribute #3795

Are you sure you want to change the base?

feat: Adds support for alertConfiguration.severityOverride attribute #3795

Conversation

ciprian-tibulca commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

lantoli Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

ciprian-tibulca Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

lantoli Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

lantoli Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

lantoli Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ciprian-tibulca Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

lantoli Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lantoli commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcosuma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EspenAlbert Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

ciprian-tibulca Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EspenAlbert commented Oct 24, 2025

Uh oh!

AgustinBettati Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ciprian-tibulca commented Oct 20, 2025 •

edited

Loading

lantoli Oct 23, 2025 •

edited

Loading

lantoli Oct 23, 2025 •

edited

Loading

lantoli commented Oct 23, 2025 •

edited

Loading

ciprian-tibulca Oct 24, 2025 •

edited

Loading