-
Notifications
You must be signed in to change notification settings - Fork 207
doc: Fixes path for collection attributes in cluster docs #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/resources/advanced_cluster.md
Outdated
-> **NOTE:** If Backup Compliance Policy is enabled for the project for which this backup schedule is defined, you cannot modify the backup schedule for an individual cluster below the minimum requirements set in the Backup Compliance Policy. See [Backup Compliance Policy Prohibited Actions and Considerations](https://www.mongodb.com/docs/atlas/backup/cloud-backup/backup-compliance-policy/#configure-a-backup-compliance-policy). | ||
|
||
-> **NOTE:** A network container is created for each provider/region combination on the advanced cluster. This can be referenced via a computed attribute for use with other resources. Refer to the `replication_specs[#].container_id` attribute in the [Attributes Reference](#attributes_reference) for more information. | ||
-> **NOTE:** A network container is created for each provider/region combination on the advanced cluster. This can be referenced via a computed attribute for use with other resources. Refer to the `replication_specs.#.container_id` attribute in the [Attributes Reference](#attributes_reference) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making doc consistent to use .#.
as used in most other docs
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
docs/data-sources/cluster.md
Outdated
- `connection_strings.private_endpoint.#.endpoints.#.endpoint_id` - Unique identifier of the private endpoint. | ||
- `connection_strings.private_endpoint.#.endpoints.#.provider_name` - Cloud provider to which you deployed the private endpoint. Atlas returns `AWS` or `AZURE`. | ||
- `connection_strings.private_endpoint.#.endpoints.#.region` - Region to which you deployed the private endpoint. | ||
- `connection_strings.#.standard` - Public mongodb:// connection string for this cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to your changes: In the docs these currently show up as a code block.
Maybe an extra space before this line would fix it. Not sure as it renders fine in github, its a registry issue only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! was an indentation issue with the code block. Fixed!
* master: chore: Allow SA for mongodbatlas_roles_org_id datasource (#3764) doc: Fixes path for collection attributes in cluster docs (#3739) build(deps): bump go.mongodb.org/atlas-sdk (#3750) doc: Add FLEX value under provider_name in advanced_cluster docs (#3763) chore: Add codegen intermediate model serialization (#3756) chore: Bump github.com/hashicorp/terraform-plugin-framework-validators (#3761) chore: Bump softprops/action-gh-release from 2.3.3 to 2.4.0 (#3759) chore: Bump actions/stale from 10.0.0 to 10.1.0 (#3758) chore: Bump peter-evans/create-or-update-comment from 4.0.0 to 5.0.0 (#3760) chore: Bump github.com/hashicorp/terraform-plugin-framework (#3762) include acceptance tests for org service account resource (#3755) chore: Add project_settings_api acceptance tests (#3751) chore: Add create only plan modifier for non-updateable attributes in autogenerated resources (#3747) # Conflicts: # go.mod # internal/service/advancedcluster/common.go # internal/service/advancedcluster/common_model_sdk_version_conversion.go # internal/service/advancedcluster/common_model_sdk_version_conversion_test.go # internal/service/advancedcluster/resource_test.go
* master: chore: Allow SA for mongodbatlas_roles_org_id datasource (#3764) doc: Fixes path for collection attributes in cluster docs (#3739) build(deps): bump go.mongodb.org/atlas-sdk (#3750) doc: Add FLEX value under provider_name in advanced_cluster docs (#3763) chore: Add codegen intermediate model serialization (#3756) chore: Bump github.com/hashicorp/terraform-plugin-framework-validators (#3761) chore: Bump softprops/action-gh-release from 2.3.3 to 2.4.0 (#3759) chore: Bump actions/stale from 10.0.0 to 10.1.0 (#3758) chore: Bump peter-evans/create-or-update-comment from 4.0.0 to 5.0.0 (#3760) chore: Bump github.com/hashicorp/terraform-plugin-framework (#3762) include acceptance tests for org service account resource (#3755) chore: Add project_settings_api acceptance tests (#3751) chore: Add create only plan modifier for non-updateable attributes in autogenerated resources (#3747) # Conflicts: # go.mod # internal/service/advancedcluster/common.go # internal/service/advancedcluster/common_model_sdk_version_conversion.go # internal/service/advancedcluster/common_model_sdk_version_conversion_test.go # internal/service/advancedcluster/resource_test.go
* master: chore: Allow SA for mongodbatlas_roles_org_id datasource (#3764) doc: Fixes path for collection attributes in cluster docs (#3739) build(deps): bump go.mongodb.org/atlas-sdk (#3750) doc: Add FLEX value under provider_name in advanced_cluster docs (#3763) chore: Add codegen intermediate model serialization (#3756) chore: Bump github.com/hashicorp/terraform-plugin-framework-validators (#3761) chore: Bump softprops/action-gh-release from 2.3.3 to 2.4.0 (#3759) chore: Bump actions/stale from 10.0.0 to 10.1.0 (#3758) chore: Bump peter-evans/create-or-update-comment from 4.0.0 to 5.0.0 (#3760) chore: Bump github.com/hashicorp/terraform-plugin-framework (#3762) include acceptance tests for org service account resource (#3755) chore: Add project_settings_api acceptance tests (#3751) chore: Add create only plan modifier for non-updateable attributes in autogenerated resources (#3747) # Conflicts: # go.mod # internal/service/advancedcluster/common.go # internal/service/advancedcluster/common_model_sdk_version_conversion.go # internal/service/advancedcluster/common_model_sdk_version_conversion_test.go # internal/service/advancedcluster/resource_test.go
* master: chore: Allow SA for mongodbatlas_roles_org_id datasource (#3764) doc: Fixes path for collection attributes in cluster docs (#3739) build(deps): bump go.mongodb.org/atlas-sdk (#3750) doc: Add FLEX value under provider_name in advanced_cluster docs (#3763) chore: Add codegen intermediate model serialization (#3756) chore: Bump github.com/hashicorp/terraform-plugin-framework-validators (#3761) chore: Bump softprops/action-gh-release from 2.3.3 to 2.4.0 (#3759) chore: Bump actions/stale from 10.0.0 to 10.1.0 (#3758) chore: Bump peter-evans/create-or-update-comment from 4.0.0 to 5.0.0 (#3760) chore: Bump github.com/hashicorp/terraform-plugin-framework (#3762) include acceptance tests for org service account resource (#3755) chore: Add project_settings_api acceptance tests (#3751) chore: Add create only plan modifier for non-updateable attributes in autogenerated resources (#3747) # Conflicts: # go.mod # internal/service/advancedcluster/common.go # internal/service/advancedcluster/common_model_sdk_version_conversion.go # internal/service/advancedcluster/common_model_sdk_version_conversion_test.go # internal/service/advancedcluster/resource_test.go
Description
Addresses this github issue #3334. While our current document does mention below note, I think it can still be confusing and inconsistent with rest of the documentation, so making minor updates to the documentation as per recommendation in the Github issue.
Adding ".#" to an attribute signifies that it is a collection attribute & it's sub-elements can be referenced with an index value such as
connection_strings[0].srv
.**NOTE** Connection strings must be returned as a list, therefore to refer to a specific attribute value add index notation.
Link to any related issue(s): CLOUDP-319584
Type of change:
Required Checklist:
Further comments