fix: Backport of "Fixes STS region resolution when using cross-region authentication (#3718)" #3731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (#3718) * update provider to infer region from sts_endpoint * changelog * fmt * nit * nit * fmt * unit tests * test * nit * nit * nit * improve clarity of comment * use asserts in unit test * use const instead of magic number --------- Co-authored-by: Oriol Arbusi Abadal <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes STS region resolution issues when using cross-region authentication in the MongoDB Atlas Terraform provider. The changes address problems where STS endpoint regions weren't being properly derived and handled in cross-region scenarios.
- Refactors STS endpoint resolution logic to properly parse and derive regions from endpoints
- Adds comprehensive test coverage for STS region derivation and endpoint resolution
- Enhances CI workflow to test cross-region authentication scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/provider/credentials.go | Refactors STS endpoint resolution with new functions to properly derive regions from endpoints |
| internal/provider/credentials_test.go | Adds comprehensive test suite for STS region derivation and endpoint resolution functions |
| .github/workflows/acceptance-tests-runner.yml | Enhances CI to test multiple cross-region authentication scenarios with matrix strategy |
| .changelog/3731.txt | Documents the bug fix in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
APIx bot: a message has been sent to Docs Slack channel |
lantoli
reviewed
Oct 1, 2025
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
There was a problem hiding this comment.
nit: I'd add it's a backport in the PR title
lantoli
approved these changes
Oct 1, 2025
oarbusi
changed the title
manupedrozo
approved these changes
Oct 1, 2025
marcosuma
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #3718 into v1 branch
Link to any related issue(s): CLOUDP-347906 & CLOUDP-348399
Type of change:
Required Checklist:
Further comments