Skip to content

test(NODE-6477): skip failing serverless tests #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2024
Merged

test(NODE-6477): skip failing serverless tests #4300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2100441
test sync
baileympearson Oct 30, 2024
63a41f0
Merge branch 'main' into DRIVERS-3021
baileympearson Oct 31, 2024
4e7e78e
asdf
baileympearson Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .evergreen/run-serverless-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ npx mocha \
test/integration/sessions/sessions.prose.test.ts \
test/integration/sessions/sessions.test.ts \
test/integration/transactions/transactions.spec.test.ts \
test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts \
test/integration/transactions/transactions.test.ts \
test/integration/versioned-api/versioned_api.spec.test.ts \
test/integration/load-balancers/load_balancers.spec.test.ts \
Expand Down
10 changes: 0 additions & 10 deletions test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@ const SKIPPED_TESTS = [
];

describe('Transactions Convenient API Spec Unified Tests', function () {
beforeEach(function () {
if (this.configuration.topologyType === 'LoadBalanced') {
if (this.currentTest) {
this.currentTest.skipReason =
'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.';
}
this.skip();
}
});

runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => {
return SKIPPED_TESTS.includes(test.description)
? 'TODO(NODE-5855): Skipping failing transaction tests'
Expand Down
7 changes: 6 additions & 1 deletion test/spec/transactions-convenient-api/unified/commit-retry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"description": "commit-retry",
"schemaVersion": "1.3",
"schemaVersion": "1.4",
"runOnRequirements": [
{
"minServerVersion": "4.0",
Expand Down Expand Up @@ -422,6 +422,11 @@
},
{
"description": "commit is not retried after MaxTimeMSExpired error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down
5 changes: 4 additions & 1 deletion test/spec/transactions-convenient-api/unified/commit-retry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: commit-retry

schemaVersion: '1.3'
schemaVersion: '1.4'

runOnRequirements:
- minServerVersion: '4.0'
Expand Down Expand Up @@ -212,6 +212,9 @@ tests:
- { _id: 1 }
-
description: commit is not retried after MaxTimeMSExpired error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down
17 changes: 16 additions & 1 deletion test/spec/transactions-convenient-api/unified/commit-writeconcernerror.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"description": "commit-writeconcernerror",
"schemaVersion": "1.3",
"schemaVersion": "1.4",
"runOnRequirements": [
{
"minServerVersion": "4.0",
Expand Down Expand Up @@ -414,6 +414,11 @@
},
{
"description": "commitTransaction is not retried after UnknownReplWriteConcern error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down Expand Up @@ -546,6 +551,11 @@
},
{
"description": "commitTransaction is not retried after UnsatisfiableWriteConcern error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down Expand Up @@ -678,6 +688,11 @@
},
{
"description": "commitTransaction is not retried after MaxTimeMSExpired error",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"name": "failPoint",
Expand Down
11 changes: 10 additions & 1 deletion test/spec/transactions-convenient-api/unified/commit-writeconcernerror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
description: commit-writeconcernerror

schemaVersion: '1.3'
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`

runOnRequirements:
- minServerVersion: '4.0'
Expand Down Expand Up @@ -151,6 +151,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after UnknownReplWriteConcern error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down Expand Up @@ -203,6 +206,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after UnsatisfiableWriteConcern error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand All @@ -226,6 +232,9 @@ tests:
outcome: *outcome
-
description: commitTransaction is not retried after MaxTimeMSExpired error
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
- name: failPoint
object: testRunner
Expand Down
5 changes: 5 additions & 0 deletions test/spec/transactions/unified/retryable-commit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@
"tests": [
{
"description": "commitTransaction fails after Interrupted",
"runOnRequirements": [
{
"serverless": "forbid"
}
],
"operations": [
{
"object": "testRunner",
Expand Down
3 changes: 3 additions & 0 deletions test/spec/transactions/unified/retryable-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ initialData:
tests:
-
description: 'commitTransaction fails after Interrupted'
runOnRequirements:
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
- serverless: forbid
operations:
-
object: testRunner
Expand Down