CLOUDP-322615: Add support for autoscaling mode in setup commands #3949
Conversation
blva
changed the title
blva
changed the title
| } | ||
|
|
||
| // newCluster creates a new cluster for the pinned API version. | ||
| func (opts *Opts) newCluster() *atlasClustersPinned.AdvancedClusterDescription { |
There was a problem hiding this comment.
this is from cluster_setup.go, I updated it a bit to simplify but added unit tests to make sure it's behaving the same
This reverts commit 27e3e32.
github-actions
bot
added
the
need-doc-review
|
APIx Bot |
: a message has been sent to Docs Slack channel 🚀.
internal/cli/setup/cluster_config.go
Outdated
| return regionConfig | ||
| } | ||
|
|
||
| // getDiskSizeOverride returns the disk size override, which is only applicable for non-tenant clusters. |
There was a problem hiding this comment.
DefaultDiskSizeGB contains values for TENANT, so this comment is not 100% correct.
var DefaultDiskSizeGB = map[string]map[string]float64{
"TENANT": {
"M2": 2,
"M5": 5,
},
"AWS": {
"M10": 10,There was a problem hiding this comment.
gotcha, it's because based on the previous implementation, it only sets the disk size override if the provider is not tenant based on if opts.providerName() != tenant { , let me see how I can rephrase it!
There was a problem hiding this comment.
updated the comment, let me know if it's better, if not we can remove it or you can make a suggestion! thanks
internal/cli/setup/cluster_config.go
Outdated
| // getDiskSizeOverride returns the disk size override, which is only applicable for non-tenant clusters. | ||
| func (opts *Opts) getDiskSizeOverride() *float64 { | ||
| if opts.providerName() != tenant { | ||
| diskSizeGB := defaultDiskSizeGB(opts.providerName(), opts.Tier) |
There was a problem hiding this comment.
When you pass an incorrect combination to defaultDiskSizeGB the value returned is 0, shouldn't we check that the value !=0 before returning?
There was a problem hiding this comment.
yes! good idea, and if it's zero we should also return nil, thank you 🙏
There was a problem hiding this comment.
updated and added unit tests, thanks!
|
Coverage Report 📉
|
Proposed changes
Jira ticket: CLOUDP-322615
--autoScalingModeChecklist
make fmtand formatted my codeFurther comments