PHPC-2617: Run Github Actions tests on PHP 8.5 #1871
Draft
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 23, 2025
| $reflection = new ReflectionClass($exception); | ||
|
|
||
| $resultDocumentProperty = $reflection->getProperty('errorLabels'); | ||
| $resultDocumentProperty->setAccessible(true); |
There was a problem hiding this comment.
Noted that this is a no-op since 8.1 (per docs), and require 8.1+ per package.xml; however, why does composer.json still say 7.4+?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2617
Note: I've excluded PHP 8.5 from the Windows Packaging jobs, as PHP 8.5 has not yet bumped its Api Version, which will lead to incompatible 8.5 packages once it does. This usually happens with the first release candidate.