Fix deserialization of primitive arrays on Big Endian systems #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes deserialization issues in PrimitivesArrayReader.cs which caused 51 test failures in the MongoDB.Bson.Tests suite on Big Endian systems (e.g., IBM s390x).
Problem
The deserialization logic relied on BitConverter.ToXxx(...) which assumes Little Endian memory layout. On Big Endian architectures, this results in incorrect values for arrays of primitive types such as Int64, Single, Double, and Decimal, leading to test failures.
Fix
Replaced unsafe BitConverter usages with BinaryPrimitives.ReadXxxLittleEndian(...) for endian-safe reads.
Covered conversions for:
Results:
51 test failures resolved.
Example fixed tests:
MemorySerializerTests.ReadonlyMemory_should_roundtrip_special_values<Int64>
MemorySerializerTests.Memory_should_roundtrip_special_values<Single>
BinaryVectorSerializerTests.BinaryVectors_should_roundtrip<float>
Pre-requisites:
s390x system (e.g., IBM Z, RHEL on s390x)
.NET 8.0 SDK installed
cc: @giritrivedi