Use uvx for CMake and Server Toolchain for Ninja #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2083. Applies similar EVG configuration updates as done in mongodb/mongo-cxx-driver#1428, but with a drive-by update to bump uv's version to 0.8.13 (latest release).
The old calls to
find_python3andPYTHON3_BINARYare removed in favor of always invoking Python viauv. All calls tofind-cmake-latest.share now replaced withinstall-build-tools.shwhich obtains a latest CMake binary + a ninja binary for (optional) use by CMake. The Ninja generator is now used by default on non-Windows distros.Batch scripts call
uvx cmakerather thanuv tool install cmake->cmaketo avoid dealing withPATH-related complications. These can/should hopefully be converted into Bash scripts and use Ninja+MSVC in the future...