Skip to content

PHPORM-326 Add collation to db:table command #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

Conversation

paulinevos
Copy link
Collaborator

@paulinevos paulinevos commented May 28, 2025

Fix PHPORM-326

Adds collation to the db:table command. Actually also adds it everywhere else in the command layer (i.e. in ShowCommand, both for views and collections), but those are not displayed when you run db:show.

Checklist

  • Add tests and ensure they pass

@paulinevos paulinevos requested a review from a team as a code owner May 28, 2025 10:06
@paulinevos paulinevos requested a review from alcaeus May 28, 2025 10:06
@alcaeus alcaeus requested review from GromNaN and removed request for alcaeus May 28, 2025 11:20
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

@paulinevos paulinevos force-pushed the 326_add-collation branch from 05acfd8 to 6caa4f2 Compare May 28, 2025 14:25
@paulinevos paulinevos requested a review from a team as a code owner May 28, 2025 14:25
@paulinevos paulinevos requested a review from norareidy May 28, 2025 14:25
@github-actions github-actions bot added the docs label May 28, 2025
@paulinevos paulinevos requested a review from GromNaN May 28, 2025 14:26
Pauline Vos added 4 commits May 28, 2025 17:30
The logic for fetching views and collections are very nearly the
same bar aggregation support.
Although it's not displayed anywhere other than `db:table` for now, the `collation`
column is present in some of laravel's artisan dabase commands.
@paulinevos paulinevos force-pushed the 326_add-collation branch from 6caa4f2 to f6e3c18 Compare May 28, 2025 15:30
@paulinevos paulinevos requested review from GromNaN and removed request for norareidy May 28, 2025 15:44
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulinevos paulinevos merged commit ea742b8 into 5.x May 28, 2025
140 checks passed
@paulinevos paulinevos deleted the 326_add-collation branch May 28, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants