Skip to content

Warn about duplicate properties in the verbose /status report #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn about duplicate properties in the verbose /status report #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/SearchIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export interface RefreshInfo {
dateStarted: Date;
dateFinished: Date | null;
elapsedMS: number | null;
duplicateProperties: string[];
}

export function joinUrl(base: string, path: string): string {
Expand Down Expand Up @@ -283,8 +284,12 @@ export class SearchIndex {
dateStarted: new Date(),
dateFinished: null,
elapsedMS: null,
duplicateProperties: [],
};

const manifestsSeen = new Set();
const duplicateManifestsSeen = [];

try {
for (const manifest of manifests) {
log.info(`Starting transaction: ${manifest.searchProperty}`);
Expand All @@ -293,6 +298,14 @@ export class SearchIndex {
assert.strictEqual(typeof manifest.manifestRevisionId, 'string');
assert.ok(manifest.manifestRevisionId);

const searchPropertyList = [manifest.searchProperty, ...(manifest.manifest.aliases || [])];
for (const property of searchPropertyList) {
if (manifestsSeen.has(property)) {
duplicateManifestsSeen.push(property);
}
manifestsSeen.add(property);
}

await session.withTransaction(async () => {
const operations: BulkWriteOperation<DatabaseDocument>[] = manifest.manifest.documents.map((document) => {
assert.strictEqual(typeof document.slug, 'string');
Expand All @@ -302,13 +315,13 @@ export class SearchIndex {
...document,
url: joinUrl(manifest.manifest.url, document.slug),
manifestRevisionId: manifest.manifestRevisionId,
searchProperty: [manifest.searchProperty, ...(manifest.manifest.aliases || [])],
searchProperty: searchPropertyList,
includeInGlobalSearch: manifest.manifest.includeInGlobalSearch,
};

return {
updateOne: {
filter: { searchProperty: newDocument.searchProperty, slug: newDocument.slug },
filter: { searchProperty: manifest.searchProperty, slug: newDocument.slug },
update: { $set: newDocument },
upsert: true,
},
Expand Down Expand Up @@ -358,6 +371,7 @@ export class SearchIndex {

status.dateFinished = new Date();
status.elapsedMS = Number(process.hrtime.bigint() - startTime) / 1000000;
status.duplicateProperties = duplicateManifestsSeen;
return status;
}
}